brand yaml logo feature parity: dashboard, revealjs

[gordonwoodhull]

Replaces #11445

Implements missing feature/format combinations for dashboard, revealjs, i.e. the Xs in the first two rows of this matrix:

I will continue with the website Xs #11309 #11310 but those are a tiny bit more complicated because I think logo resolution needs to happen later:

quarto-cli/src/project/types/website/website-shared.ts

Lines 167 to 179 in f38a78d

	const projectBrand = await project.resolveBrand();
	if (
	projectBrand?.processedData.logo && sidebars?.[0]
	) {
	if (sidebars[0].logo === undefined) {
	const logo = projectBrand.processedData.logo.medium ??
	projectBrand.processedData.logo.small ??
	projectBrand.processedData.logo.large;
	if (logo) {
	sidebars[0].logo = logo.light.path; // TODO: This needs smarts to work on light+dark themes
	sidebars[0]["logo-alt"] = logo.light.alt;
	}
	}

It is my understanding that project.resolveBrand() should never be called without a target, but we don't have one at this point.

Notes:

• revealjs does not currently have alt text for the logo, so I did not implement it.
• no support for dark mode - I think this would be easy but I haven’t looked.

[cscheid]

project.resolveBrand() without a target

FWIW, it takes an optional fileName; when missing, it only attempts to resolve the project-level brand information.

[gordonwoodhull]

I said that too strongly.

Yes, it is currently fetching project-level brand data correctly. The problem is that project-level brand data may be unexpected since we have a couple of ways to assign document-level brand data.

Today I’m going to try loading the logo at document level, to allow embedded brand data and document choice of logo. If it’s not possible or causes problems I’ll give up and accept the inconsistency.

[cscheid]

That inconsistency is not a show-stopper by any means.