Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callout rendering in gfm #6935

Closed
cscheid opened this issue Sep 21, 2023 · 3 comments · Fixed by #6942
Closed

Callout rendering in gfm #6935

cscheid opened this issue Sep 21, 2023 · 3 comments · Fixed by #6942
Assignees
@cscheid
Labels
ast issues related to AST processing enhancement New feature or request
Milestone
v1.4

Comments

@cscheid
Copy link
Collaborator

cscheid commented Sep 21, 2023

This should be a matter of adding a custom renderer for the Callout node in gfm output.
@cscheid cscheid added enhancement New feature or request ast issues related to AST processing labels Sep 21, 2023
@cscheid cscheid added this to the v1.4 milestone Sep 21, 2023
@cscheid cscheid self-assigned this Sep 21, 2023
@cscheid
Copy link
Collaborator Author

cscheid commented Sep 21, 2023

See #1495

@cderv
Copy link
Collaborator

cderv commented Sep 21, 2023

Just a note that this is still in Beta : github.com/orgs/community/discussions/16925

Let us know what you think and how this helps you provide better documentation. Please note that this is a beta feature that might be subject to change.

With a few updates since May 2022.

I can't find any other mention in Github doc, spec or blog post.

@cscheid
Copy link
Collaborator Author

cscheid commented Sep 21, 2023

Good to know. With that said, it's really very easy for us to do, so it wouldn't be hard to change our rendering if they change their syntax.

cscheid added a commit that referenced this issue Sep 21, 2023
@cscheid
format callout for gfm output. Closes #6935
918822a
@cscheid cscheid mentioned this issue Sep 21, 2023
Merged
cscheid added a commit that referenced this issue Sep 22, 2023
@cscheid
Render callouts to GFM (#6942)
f9bb1eb 
* format callout for gfm output. Closes #6935
* detect gfm robustly
* changelog
@cderv cderv mentioned this issue Oct 24, 2023
Open
@cwickham cwickham mentioned this issue Dec 12, 2023
Closed
45 tasks
@cwickham cwickham mentioned this issue Jan 17, 2024
Open
11 tasks
@jayhesselberth jayhesselberth mentioned this issue Jul 7, 2024
Open
@mcanouil mcanouil mentioned this issue Sep 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cscheid cscheid

Labels
ast issues related to AST processing enhancement New feature or request
Projects
None yet
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

Render callouts to GFM quarto-dev/quarto-cli
2 participants
@cscheid @cderv