Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revealjs export pdf changes code block font #9699

Closed
bcm0 opened this issue May 16, 2024 · 4 comments · Fixed by #10361
Closed

revealjs export pdf changes code block font #9699

bcm0 opened this issue May 16, 2024 · 4 comments · Fixed by #10361
Assignees
Labels
bug Something isn't working revealjs Issues with the revealjs format upstream Bug is in upstream library
Milestone

Comments

@bcm0
Copy link

bcm0 commented May 16, 2024

Bug description

Fonts in code blocks change and line highlighting is deleted

Steps to reproduce

Visit https://quarto.org/docs/presentations/revealjs/demo/#/line-highlighting look at the font, press e key and scroll down again to see the changed font

Expected behavior

The font should stay the same

Actual behavior

The font changes

Your environment

No response

Quarto check output

No response

@bcm0 bcm0 added the bug Something isn't working label May 16, 2024
@mcanouil
Copy link
Collaborator

I cannot reproduce any font change.

I don't thing there is a bug here even with the "different animation".

image image

@mcanouil mcanouil added revealjs Issues with the revealjs format labels May 16, 2024
@bcm0
Copy link
Author

bcm0 commented May 16, 2024

I cannot reproduce any font change.

Thank you for your quick reply. I can clearly see the font change in your screenshots because the font changed from sans-serif to serif and 0,=,* look different.

I tried the revealjs demo and there's no font change during pdf export and the line highlighting works.

https://revealjs.com/demo/#/4

https://revealjs.com/demo/?print-pdf

@cderv
Copy link
Collaborator

cderv commented May 17, 2024

About the overwrite, this is an issue in Revealjs, fixed in 4.6

We'll update to v5 for next release, so it should fix it.

For the highlighting, Quarto does not use the same tool that reveal, so maybe we need to add some specific CSS rules to the print version. We'll see that after v5 update.

@cderv cderv self-assigned this May 17, 2024
@cderv cderv added this to the v1.5 milestone May 17, 2024
@cscheid cscheid modified the milestones: v1.5, Future Jun 18, 2024
@cscheid cscheid added the upstream Bug is in upstream library label Jun 18, 2024
@cderv cderv modified the milestones: Future, v1.6 Aug 29, 2024
@cderv
Copy link
Collaborator

cderv commented Aug 29, 2024

This is now working with Quarto 1.6.9 which has Revealjs 5.1.0 update

@cderv cderv closed this as completed Aug 29, 2024
@cderv cderv linked a pull request Aug 29, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working revealjs Issues with the revealjs format upstream Bug is in upstream library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants