Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update revealjs v5 and dependencies #10361

Merged
merged 24 commits into from
Aug 29, 2024
Merged

Update revealjs v5 and dependencies #10361

merged 24 commits into from
Aug 29, 2024

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Jul 23, 2024

Towards

This PR includes docs and process to update revealjs theming. It helps understand how this currently works to maps Sass variables from user's theming, to quarto internals, and then to expected Reveal.js own SASS theming system.

We probably need more tests as most of the change will have effect in browser running JS code for reveal, so we don't have much test with this yet.

Manual testing

@cscheid
Copy link
Collaborator

cscheid commented Jul 23, 2024

This looks great!

Keeping in mind the upcoming posit::conf presentations, we should either:

  • merge ASAP (as in today), or
  • merge the day after posit::conf is done

What do you think?

@cderv
Copy link
Collaborator Author

cderv commented Jul 23, 2024

😄 definitely the main question. I ask myself the same, hence the draft state. We have a stable release working we could also consider that anyone doing a presentation for "production" (posit::conf) would use a stable version and not a pre-release 😉 Though our users likes to live on the edge of new stuff ! 😆

I don't think the effect if big, but we don't really have test regarding how feature works in in a live browser situation so it requires manual testing. And I am just starting them.

Could be small or no effect, but could also be the opposite 🤷‍♂️. So considering the milestone of conf, we should probably let this in a branch. This also leave me time to add to this, rebasing often on main and adding some tests.

What is your take on this ?

@cscheid
Copy link
Collaborator

cscheid commented Jul 23, 2024

You have the hands-on experience.

So considering the milestone of conf, we should probably let this in a branch.

That works for me. Let's plan to merge right after conf.

@cderv cderv force-pushed the revealjs/update-v5 branch 2 times, most recently from 1a9fdb8 to 4dcc897 Compare July 25, 2024 10:46
@cderv cderv changed the title Update revealjs dependencies Update revealjs v5 and dependencies Jul 26, 2024
@cderv

This comment was marked as resolved.

@cderv

This comment was marked as outdated.

@cderv
Copy link
Collaborator Author

cderv commented Jul 26, 2024

Nevermind, it seems it is fixed upstream:

We need an unreleased version of chalkboard.

@cderv cderv force-pushed the revealjs/update-v5 branch from 21a5877 to 8e4eea4 Compare August 26, 2024 08:38
this is an unreleased version with a fix for Reveal.js 5.0.3 change regarding overlay styling
@cderv cderv force-pushed the revealjs/update-v5 branch from 8e4eea4 to dcd1724 Compare August 29, 2024 08:42
@cderv cderv marked this pull request as ready for review August 29, 2024 13:16
@cderv
Copy link
Collaborator Author

cderv commented Aug 29, 2024

Very small theme change after all, and it is now more inline with revealjs own theme.

All good to merge this PR so I'll go ahead.

I'll update documentation for 1.6 to close #4795 , including adding an highlight

@cderv cderv merged commit 347a732 into main Aug 29, 2024
47 checks passed
@cderv cderv deleted the revealjs/update-v5 branch August 29, 2024 13:58
cderv added a commit that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

revealjs export pdf changes code block font Slide Number Issues with RevealJS's print-pdf and h1 sections
2 participants