Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StdJDBCDelegate.selectTriggerToAcquire may not respect maxCount #491

Closed
bradbeck opened this issue Sep 12, 2019 · 0 comments
Closed

StdJDBCDelegate.selectTriggerToAcquire may not respect maxCount #491

bradbeck opened this issue Sep 12, 2019 · 0 comments

Comments

@bradbeck
Copy link
Contributor

quartz/quartz-core/src/main/java/org/quartz/impl/jdbcjobstore/StdJDBCDelegate.java

Line 2615 in ce1650f

while (rs.next() && nextTriggers.size() <= maxCount) {

In cases where the JDBC driver does not respect PreparedStatement.setFetchSize and PreparedStatement.setMaxRows, the current logic may return more than maxCount results.
@bradbeck bradbeck mentioned this issue Sep 12, 2019
Closed
chrisdennis added a commit to chrisdennis/quartz that referenced this issue Oct 4, 2019
@chrisdennis
Issue quartz-scheduler#491 : Added unit test coverage
d38c941
chrisdennis added a commit to chrisdennis/quartz that referenced this issue Oct 23, 2019
@chrisdennis
Issue quartz-scheduler#491 : Added unit test coverage
71b8262
chrisdennis added a commit to chrisdennis/quartz that referenced this issue Oct 23, 2019
@chrisdennis
Issue quartz-scheduler#491 : Added unit test coverage
9dddfd6
chrisdennis added a commit to chrisdennis/quartz that referenced this issue Oct 23, 2019
@chrisdennis
Issue quartz-scheduler#491 : Added unit test coverage
de69c46
chrisdennis added a commit that referenced this issue Oct 23, 2019
@chrisdennis
Merge pull request #520 from chrisdennis/issue-491-2.3.x
c069965 
Issue #491 [2.3.x]
This was referenced Mar 8, 2021
Open
Merged
Open
Closed
This was referenced Mar 16, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bradbeck