Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exceptions thrown while retrieving the misfired triggers #1260

Merged

Conversation

ohksj77
Copy link
Contributor

@ohksj77 ohksj77 commented Nov 10, 2024

This PR...

Fix #1152

Changes

  • handled exceptions thrown while retrieving the misfired triggers

Checklist

  • tested locally
  • updated the docs
  • added appropriate test
  • signed-off on the DCO referenced in the CONTRIBUTING link below via git commit -s on my commits, and submit this code under terms of the Apache 2.0 license and assign copyright to the Quartz project owners
    (If you're not using command-line, you can use a browser extension )

In submitting this contribution, I agree to the terms of contributing as referred to here:
https://github.com/quartz-scheduler/contributing/blob/main/CONTRIBUTING.md

Signed-off-by: 김승진 <ohksj77@gmail.com>
@melloware
Copy link
Contributor

If you change your comment from Fixes issue #1152 to Fix #1152 it will link this PR to the ticket.

@melloware
Copy link
Contributor

Can you also make another PR for the 2.4 branch of this fix?

@ohksj77
Copy link
Contributor Author

ohksj77 commented Nov 10, 2024

Can you also make another PR for the 2.4 branch of this fix?

Okay, I'll make a PR for the 2.4 branch too.

@ohksj77
Copy link
Contributor Author

ohksj77 commented Nov 10, 2024

I created a new PR on branch 2.4: #1261
If you need anything else, feel free to talk to me.

@melloware
Copy link
Contributor

@ohksj77 this looks great! do you mind checking this ticket and see if your fixes fix this issue: #1245

@ohksj77
Copy link
Contributor Author

ohksj77 commented Nov 10, 2024

@ohksj77 this looks great! do you mind checking this ticket and see if your fixes fix this issue: #1245

Okay, I'll give it a try and share. Thank you!

@ohksj77
Copy link
Contributor Author

ohksj77 commented Nov 10, 2024

@melloware My fix doesn't seem to affect the issue.
I tried running both the version I fixed and the previous version, following the reproduction steps, and found the same results in both cases.

@melloware
Copy link
Contributor

Ok thanks for checking!

Copy link
Contributor

@jhouserizer jhouserizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is an improvement. But there is still some strange/undefined ambiguity around what does and what should happen to triggers that fail to load during misfire handling ... someday somebody needs to think more about that. :)

@jhouserizer jhouserizer merged commit cbe23a1 into quartz-scheduler:main Nov 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MisfireHandler cannot recover any triggers if one misfired trigger has errors
3 participants