-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle exceptions thrown while retrieving the misfired triggers #1260
Handle exceptions thrown while retrieving the misfired triggers #1260
Conversation
Signed-off-by: 김승진 <ohksj77@gmail.com>
If you change your comment from |
Can you also make another PR for the 2.4 branch of this fix? |
Okay, I'll make a PR for the 2.4 branch too. |
I created a new PR on branch 2.4: #1261 |
@melloware My fix doesn't seem to affect the issue. |
Ok thanks for checking! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This is an improvement. But there is still some strange/undefined ambiguity around what does and what should happen to triggers that fail to load during misfire handling ... someday somebody needs to think more about that. :)
This PR...
Fix #1152
Changes
Checklist
git commit -s
on my commits, and submit this code under terms of the Apache 2.0 license and assign copyright to the Quartz project owners(If you're not using command-line, you can use a browser extension )
In submitting this contribution, I agree to the terms of contributing as referred to here:
https://github.com/quartz-scheduler/contributing/blob/main/CONTRIBUTING.md