refactor: order of impl matches trait

rust/quary-databases/src/databases_bigquery.rs

@@ -3,7 +3,7 @@
 use gcp_bigquery_client::error::BQError;
 use gcp_bigquery_client::model::query_request::QueryRequest;
 use gcp_bigquery_client::Client;
 use google_cloud_auth::project::{create_token_source, Config};
 use google_cloud_auth::token_source::TokenSource;
 use quary_core::database_bigquery::DatabaseQueryGeneratorBigQuery;
 use quary_core::databases::{
@@ -101,7 +101,7 @@
                 sub: None,
             };
             // Assuming `create_token_source` returns a `Result<impl TokenSource, Error>`
             let ts = create_token_source(config)
                 .await
                 .map_err(|e| format!("Failed to create token source: {}", e))?;
 
@@ -280,14 +280,14 @@
         })
     }
 
-    async fn table_exists(&self, _path: &str) -> Result<Option<bool>, String> {
-        Ok(None) // not implemented
-    }
-
     fn query_generator(&self) -> Box<dyn DatabaseQueryGenerator> {
         Box::new(DatabaseQueryGeneratorBigQuery::new(
             self.project_id.to_string(),
             self.dataset_id.to_string(),
         ))
     }
+
+    async fn table_exists(&self, _path: &str) -> Result<Option<bool>, String> {
+        Ok(None) // not implemented
+    }
 }

rust/quary-databases/src/databases_duckdb.rs

@@ -209,13 +209,13 @@
         })
     }
 
-    async fn table_exists(&self, _path: &str) -> Result<Option<bool>, String> {
-        Ok(None) // not implemented
-    }
-
     fn query_generator(&self) -> Box<dyn DatabaseQueryGenerator> {
         Box::new(DatabaseQueryGeneratorDuckDB::new(self.schema.clone(), None))
     }
+
+    async fn table_exists(&self, _path: &str) -> Result<Option<bool>, String> {
+        Ok(None) // not implemented
+    }
 }
 
 fn convert_array_to_vec_string(array: &[Arc<dyn Array>]) -> Result<Vec<Vec<String>>, String> {
@@ -227,7 +227,7 @@
         rows.push(row);
     }
 
     for i in 0..num_rows {
         for j in 0..array.len() {
             let array = &array[j];
             if let Some(string_array) = array.as_any().downcast_ref::<array::StringArray>() {
@@ -866,7 +866,7 @@
             .unwrap();
 
         // Convert NaiveDateTime to DateTime<Utc>
         let datetime_utc = DateTime::<Utc>::from_utc(naive_datetime, Utc);
 
         // Convert DateTime<Utc> to SystemTime
         let system_time = SystemTime::from(datetime_utc);
@@ -986,7 +986,7 @@
             NaiveDateTime::parse_from_str(datetime_str_updated, "%Y-%m-%d %H:%M:%S")
                 .unwrap();
 
         // Convert NaiveDateTime to DateTime<Utc>
         let datetime_utc_updated = DateTime::<Utc>::from_utc(naive_datetime_updated, Utc);
 
         // Convert DateTime<Utc> to SystemTime
@@ -1073,7 +1073,7 @@
         let naive_datetime = NaiveDateTime::parse_from_str(datetime_str, "%Y-%m-%d %H:%M:%S")
             .unwrap();
 
         // Convert NaiveDateTime to DateTime<Utc>
         let datetime_utc = DateTime::<Utc>::from_utc(naive_datetime, Utc);
 
         // Convert DateTime<Utc> to SystemTime
@@ -1193,7 +1193,7 @@
         let naive_datetime_updated =
             NaiveDateTime::parse_from_str(datetime_str_updated, "%Y-%m-%d %H:%M:%S")
                 .unwrap();
 
         // Convert NaiveDateTime to DateTime<Utc>
         let datetime_utc_updated = DateTime::<Utc>::from_utc(naive_datetime_updated, Utc);
 

rust/quary-databases/src/databases_postgres.rs

@@ -21,7 +21,7 @@
 
 impl Postgres {
     // TODO This should be a builder pattern or something else
     pub async fn new(
         host: &str,
         port: Option<String>,
         user: &str,
@@ -110,7 +110,7 @@
             .map(|row| {
                 let table_schema: String = row
                     .try_get(0)
                     .map_err(|e| format!("Error getting table schema: {}", e.to_string()))?;
                 let table_name: String = row
                     .try_get(1)
                     .map_err(|e| format!("Error getting table name: {}", e.to_string()))?;
@@ -324,16 +324,16 @@
         })
     }
 
-    async fn table_exists(&self, _path: &str) -> Result<Option<bool>, String> {
-        Ok(None) // not implemented
-    }
-
     fn query_generator(&self) -> Box<dyn DatabaseQueryGenerator> {
         Box::new(DatabaseQueryGeneratorPostgres::new(
             self.schema.clone(),
             None,
         ))
     }
+
+    async fn table_exists(&self, _path: &str) -> Result<Option<bool>, String> {
+        Ok(None) // not implemented
+    }
 }
 
 #[cfg(test)]
@@ -1174,7 +1174,7 @@
         database.exec("CREATE SCHEMA jaffle_shop").await.unwrap();
 
         let datetime_str = "2023-01-01 01:00:00";
 
         // Parse the string into a NaiveDateTime
         let naive_datetime = NaiveDateTime::parse_from_str(datetime_str, "%Y-%m-%d %H:%M:%S")
             .unwrap();
@@ -1297,7 +1297,7 @@
             .unwrap();
 
         let datetime_str_updated = "2023-01-01 03:00:00";
 
         // Parse the string into a NaiveDateTime
         let naive_datetime_updated =
             NaiveDateTime::parse_from_str(datetime_str_updated, "%Y-%m-%d %H:%M:%S")

rust/quary-databases/src/databases_redshift.rs

@@ -86,6 +86,13 @@
         self.postgres.query(query).await
     }
 
+    fn query_generator(&self) -> Box<dyn DatabaseQueryGenerator> {
+        Box::new(DatabaseQueryGeneratorRedshift::new(
+            self.schema.clone(),
+            None,
+        ))
+    }
+
     async fn table_exists(&self, path: &str) -> Result<Option<bool>, String> {
         let parts: Vec<&str> = path.split('.').collect();
         let (schema, table) = match parts.len() {
@@ -100,13 +107,6 @@
             .await?;
         Ok(Some(result.len() > 0))
     }
-
-    fn query_generator(&self) -> Box<dyn DatabaseQueryGenerator> {
-        Box::new(DatabaseQueryGeneratorRedshift::new(
-            self.schema.clone(),
-            None,
-        ))
-    }
 }
 
 #[cfg(test)]
@@ -658,7 +658,7 @@
         database.exec("CREATE SCHEMA jaffle_shop").await.unwrap();
 
         let datetime_str = "2023-01-01 01:00:00";
 
         // Parse the string into a NaiveDateTime
         let naive_datetime = NaiveDateTime::parse_from_str(datetime_str, "%Y-%m-%d %H:%M:%S")
             .unwrap();
@@ -782,7 +782,7 @@
                 .unwrap();
 
         let datetime_str_updated = "2023-01-01 03:00:00";
 
         // Parse the string into a NaiveDateTime
         let naive_datetime_updated =
             NaiveDateTime::parse_from_str(datetime_str_updated, "%Y-%m-%d %H:%M:%S")

rust/quary-databases/src/databases_snowflake.rs

@@ -284,16 +284,16 @@ impl DatabaseConnection for Snowflake {
         };
     }
 
-    async fn table_exists(&self, _path: &str) -> Result<Option<bool>, String> {
-        Ok(None) // not implemented
-    }
-
     fn query_generator(&self) -> Box<dyn DatabaseQueryGenerator> {
         Box::new(DatabaseQueryGeneratorSnowflake::new(
             self.database.to_string(),
             self.schema.to_string(),
         ))
     }
+
+    async fn table_exists(&self, _path: &str) -> Result<Option<bool>, String> {
+        Ok(None) // not implemented
+    }
 }
 
 pub fn convert_array_to_vec_string(

rust/quary-databases/src/databases_sqlite.rs

@@ -149,13 +149,13 @@ impl DatabaseConnection for Sqlite {
         })
     }
 
-    async fn table_exists(&self, _path: &str) -> Result<Option<bool>, String> {
-        Ok(None) // not implemented
-    }
-
     fn query_generator(&self) -> Box<dyn DatabaseQueryGenerator> {
         Box::new(DatabaseQueryGeneratorSqlite {})
     }
+
+    async fn table_exists(&self, _path: &str) -> Result<Option<bool>, String> {
+        Ok(None) // not implemented
+    }
 }
 
 #[cfg(test)]