Skip to content

Conversation

@n05la3
Copy link
Contributor

@n05la3 n05la3 commented Feb 12, 2025

…install for TypeScript using npm #384

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • New test runner
  • Documentation
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

If you are adding a new test runner, have you...? (check all)

  • Created an issue first?
  • Registered it in /packages/base/runners.json?
  • Added it to /README.md?
  • Included one test that runs baseline.spec.vue?
  • Added and updated documentation?
  • Included a recipe folder with properly building quasar project?

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on Windows
  • It's been tested on Linux
  • It's been tested on MacOS
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@n05la3 n05la3 force-pushed the fix/vitest-ts-install branch from 28d1fb1 to 60c4b4c Compare February 14, 2025 17:16
@n05la3 n05la3 marked this pull request as ready for review February 17, 2025 14:42
Copy link
Member

@yusufkandemir yusufkandemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is Vitest v1 which requires Vite 5, not Vitest v2
https://vitest.dev/guide/migration.html#migrating-to-vitest-1-0

yusufkandemir

This comment was marked as duplicate.

@marvin-wtt
Copy link

Any chance we get this merged now?

@n05la3 n05la3 force-pushed the fix/vitest-ts-install branch 2 times, most recently from 167b769 to 4283ec6 Compare March 28, 2025 12:05
@mtdvlpr
Copy link

mtdvlpr commented Apr 3, 2025

Is there an ETA when this might be merged so #389 can be closed?

@IlCallo IlCallo force-pushed the fix/vitest-ts-install branch from 4283ec6 to ee8e170 Compare April 29, 2025 12:43
@IlCallo IlCallo merged commit cdae0a5 into quasarframework:dev Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants