-
Notifications
You must be signed in to change notification settings - Fork 68
fix(vitest): correctly set vitest version depending on vite version, fix #384 #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28d1fb1 to
60c4b4c
Compare
yusufkandemir
requested changes
Mar 10, 2025
Member
yusufkandemir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is Vitest v1 which requires Vite 5, not Vitest v2
https://vitest.dev/guide/migration.html#migrating-to-vitest-1-0
|
Any chance we get this merged now? |
167b769 to
4283ec6
Compare
|
Is there an ETA when this might be merged so #389 can be closed? |
Closed
23 tasks
…install for TypeScript using npm quasarframework#384
Co-authored-by: Yusuf Kandemir <y.kandemir@dreamonkey.com>
…scaffold Vitest 3 by default
4283ec6 to
ee8e170
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…install for TypeScript using npm #384
What kind of change does this PR introduce? (check at least one)
If you are adding a new test runner, have you...? (check all)
/packages/base/runners.json?/README.md?baseline.spec.vue?Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch and not themasterbranchfix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: