Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dialog.md #16416

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Update dialog.md #16416

merged 1 commit into from
Sep 30, 2023

Conversation

angelhdzdev
Copy link
Contributor

@angelhdzdev angelhdzdev commented Sep 30, 2023

Caught a typo while reading the docs of Dialog plugin to modify my app.

"3. A simple confirmation dialog, where the user can cancel or give her “ok” for a particular action or input."

It should be "their", not "her" or "his".

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

Caught a typo while reading the docs of Dialog plugin to modify my app. 

"3. A simple confirmation dialog, where the user can cancel or give her “ok” for a particular action or input."

It should be "their", not "her" or "his".
@rstoenescu rstoenescu merged commit 6f88c71 into quasarframework:dev Sep 30, 2023
@rstoenescu
Copy link
Member

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants