up go to 1.18 to support generics code #203
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terminator637
commented
Oct 6, 2022
| @@ -6,7 +6,6 @@ | |||
| "fast": false, | |||
| "linters": { | |||
| "enable": [ | |||
There was a problem hiding this comment.
All deleted linters now are deprecated in favor of unused linter.
Terminator637
commented
Oct 6, 2022
| @@ -6,8 +6,8 @@ package imports | |||
| // otherwise a parsing error will be returned. | |||
| // | |||
| // We perform these operations: | |||
| // 1. Remove unused imports from a file. | |||
There was a problem hiding this comment.
golangci-lint says that file is not gofmt-ed with -s, fixed it.
Terminator637
commented
Oct 6, 2022
| @@ -15,6 +15,5 @@ func TestRulesGo1_18(t *testing.T) { | |||
| if ver := testVersionConstraints[key]; ver != "1.18" { | |||
| continue | |||
| } | |||
| runRulesTest(t, key) | |||
There was a problem hiding this comment.
still have no idea what to do this function, temporary deleted it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up go to 1.18 and other necessary dependencies to make perfguard work with generics code. But still have no idea what to do with missing function runRulesTest(t, key).