Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

precompiled IR dumping can be more compact #326

Closed
quasilyte opened this issue Dec 28, 2021 · 0 comments · Fixed by #351
Closed

precompiled IR dumping can be more compact #326

quasilyte opened this issue Dec 28, 2021 · 0 comments · Fixed by #351

Comments

@quasilyte
Copy link
Owner

quasilyte commented Dec 28, 2021 •
edited
Loading

Printing ir.PatternString type inside a slice is redundant.

					SyntaxPatterns: []ir.PatternString{
						ir.PatternString{Line: 11, Value: "fmt.Sprint($x)"},
						ir.PatternString{Line: 11, Value: "fmt.Sprintf(\"%s\", $x)"},
						ir.PatternString{Line: 11, Value: "fmt.Sprintf(\"%v\", $x)"},
					},

Same for ir.RuleGroup{ and ir.Rule{. There is no need to specify a type.

DocTags should be printed on a single line.
quasilyte added a commit that referenced this issue Jan 6, 2022
@quasilyte
ruleguard/irprint: make printed IR ~15% more compact
d4e99aa 
This is important for big rule sets that can produce large Go files.

Fixes #326
@quasilyte quasilyte mentioned this issue Jan 6, 2022
Merged
quasilyte added a commit that referenced this issue Jan 6, 2022
@quasilyte
ruleguard/irprint: make printed IR ~15% more compact (#351)
cc33ba4 
This is important for big rule sets that can produce large Go files.

Fixes #326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ruleguard/irprint: make printed IR ~15% more compact quasilyte/go-ruleguard
1 participant
@quasilyte