ruleguard: autofix some interpolated expressions #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given this pattern: io.WriteString($w, $s) And this input string: io.WriteString(&buf, s) With this replacement template: $w.WriteString($s) We'll get this result: &buf.WriteString(s) That's incorrect. To avoid that, ruleguard attempts to fix some interpolated expressions when it can understand the context. In the cases above, it sees that variable is followed by `.` while `$w` contains unary `&` expression. It knows that `$w.x` is identical to `(&$w).w`, so we can simply insert `buf` instead of `&buf` and get `buf.WriteString(s)`. This greatly simplifies the creation of reliable rules that just work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given this pattern:
And this input string:
With this replacement template:
We'll get this result:
That's incorrect.
To avoid that, ruleguard attempts to fix some interpolated
expressions when it can understand the context.
In the cases above, it sees that variable is followed by
.while
$wcontains unary&expression. It knows that$w.xis identical to(&$w).w, so we can simply insertbufinstead of&bufand getbuf.WriteString(s).This greatly simplifies the creation of reliable rules
that just work.