add global property for Var #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quasilyte
reviewed
Jan 31, 2022
quasilyte
reviewed
Feb 1, 2022
quasilyte
reviewed
Feb 1, 2022
| var globalVar2 string = time.Now().String() // want `\Qglobal var` | ||
| var globalVar3 = time.Now().String() // want `\Qglobal var` | ||
| var _ = time.Now().String() // false negative // TODO https://github.com/quasilyte/go-ruleguard/issues/369 | ||
| var _ string = time.Now().String() // false negative // TODO https://github.com/quasilyte/go-ruleguard/issues/369 |
There was a problem hiding this comment.
I think all _ share the same "object" (none, nil object).
So they define "nothing".
Since you basically should use this IsGlobal not for a declaration but rather for the usage of some variable, I don't think these cases matter here.
There was a problem hiding this comment.
We can't have different types for nil object either. Simply because there is nothing to associate a type with.
|
The code is good. |
|
The new dsl version is |
quasilyte
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.