Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CurveIn Arrow #31

Merged
merged 3 commits into from
May 10, 2023
Merged

CurveIn Arrow #31

merged 3 commits into from
May 10, 2023

Conversation

dmoroz0v
Copy link
Contributor

@dmoroz0v dmoroz0v commented May 9, 2023

Screenshot 2023-05-09 at 21 24 36

bring-shrubbery
bring-shrubbery previously approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@bring-shrubbery bring-shrubbery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I don't mind the naming, I think when someone needs to add more shapes they can rename it. Thanks for the extra previews by the way.

Sources/SwiftUITooltip/TooltipModifier.swift Outdated Show resolved Hide resolved
@bring-shrubbery
Copy link
Member

bring-shrubbery commented May 9, 2023 •
edited
Loading

@dmoroz0v Tell me if you want to change that comment or not, and we can merge I think.

@bring-shrubbery bring-shrubbery added the enhancement New feature or request label May 9, 2023
@dmoroz0v dmoroz0v changed the title curve arrow CurveIn Arrow May 10, 2023
@dmoroz0v
Copy link
Contributor Author

@bring-shrubbery hi. pr is ready for review

@bring-shrubbery
Copy link
Member

Thanks for this PR @dmoroz0v ❤️

@bring-shrubbery bring-shrubbery enabled auto-merge (squash) May 10, 2023 10:54
@bring-shrubbery bring-shrubbery merged commit 3bef9a2 into quassum:main May 10, 2023
@dmoroz0v dmoroz0v deleted the cure-arrow branch July 25, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bring-shrubbery bring-shrubbery bring-shrubbery approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmoroz0v @bring-shrubbery