Tools #27

mrharpo · 2020-02-28T02:00:30Z

First round of TimelineTools and related functionality!!!

Added:

time - select time in clip
trim - change inpoint/outpoint
- changes cursor to distinguish between inpoint and outpoint, Clip drag adjust selection #21
cut - split clip into two, and update Edl Add 'razor' tool to split clips #13
move - drag resort clips

Plus numerous other fixes and improvements, including:

Better "mobile first" inline layout Mobile Swipe #15
Fixed duplicate clips on drag sort
Fixed time comparisons
Simplified component calculations
Added title text to Clips

And many more!

normakster · 2020-02-29T21:53:57Z

Cannot test due to the following:

The following error on the "dev" server caused by ... i/o error, open '/app/dist/Menu.map'.
Possible culprit: the /dist directory is "in use" or corrupted in the repo. Suggest removing and recreating. I've stop the services, restarted docker, restarted my machine, toggled branches and it's still stuck.

Logs:

$npm install
$docker-compose -f docker-compose.yml -f dev.yml up --build

[... build successful output omitted ...]

Starting alfred_dev_1 ... done                                   
Starting alfred_api_1 ... done                                   
Attaching to alfred_api_1, alfred_dev_1
api_1  | Checking for script in /app/prestart.sh
api_1  | Running script /app/prestart.sh
api_1  | Running inside /app/prestart.sh, you could add migrations to this file, e.g.:
api_1  |
api_1  | #! /usr/bin/env bash
api_1  |
api_1  | # Let the DB start
api_1  | sleep 10;
api_1  | # Run migrations
api_1  | alembic upgrade head
api_1  |
api_1  | INFO: Uvicorn running on http://0.0.0.0:80 (Press CTRL+C to quit)
api_1  | INFO: Started reloader process [1]
api_1  | INFO: Started server process [7]
api_1  | INFO: Waiting for application startup.
dev_1  | events.js:182
dev_1  |       throw er; // Unhandled 'error' event
dev_1  |       ^
dev_1  |
dev_1  | Error: EIO: i/o error, open '/app/dist/Menu.map'
alfred_dev_1 exited with code 1

mrharpo · 2020-03-06T00:30:44Z

Fixes #5 - tools palette differentiates between actions

mrharpo · 2020-03-06T07:07:00Z

Partial fix for #12 - export function now downloads rendered file.

normakster · 2020-03-06T20:31:40Z

Cannot test due to the following:

The following error on the "dev" server caused by ... i/o error, open '/app/dist/Menu.map'.
Possible culprit: the /dist directory is "in use" or corrupted in the repo. Suggest removing and recreating. I've stop the services, restarted docker, restarted my machine, toggled branches and it's still stuck.

Fixed the error by making the "api" service depend_on: - dev in the docker-compose.yml

normakster · 2020-03-06T20:32:34Z

Ran into a couple issues related to missing media files. Do we have error handling slated for this?

api_1  | INFO: ('192.168.48.1', 33748) - "GET /videos/train.mp4 HTTP/1.1" 500
api_1  | ERROR: Exception in ASGI application
api_1  | Traceback (most recent call last):
api_1  |   File "/usr/local/lib/python3.7/site-packages/uvicorn/protocols/http/httptools_impl.py", line 375, in run_asgi
api_1  |     result = await app(self.scope, self.receive, self.send)
api_1  |   File "/usr/local/lib/python3.7/site-packages/fastapi/applications.py", line 140, in __call__
api_1  |     await super().__call__(scope, receive, send)
api_1  |   File "/usr/local/lib/python3.7/site-packages/starlette/applications.py", line 134, in __call__
api_1  |     await self.error_middleware(scope, receive, send)
api_1  |   File "/usr/local/lib/python3.7/site-packages/starlette/middleware/errors.py", line 178, in __call__
api_1  |     raise exc from None
api_1  |   File "/usr/local/lib/python3.7/site-packages/starlette/middleware/errors.py", line 156, in __call__
api_1  |     await self.app(scope, receive, _send)
api_1  |   File "/usr/local/lib/python3.7/site-packages/starlette/exceptions.py", line 73, in __call__
api_1  |     raise exc from None
api_1  |   File "/usr/local/lib/python3.7/site-packages/starlette/exceptions.py", line 62, in __call__
api_1  |     await self.app(scope, receive, sender)
api_1  |   File "/usr/local/lib/python3.7/site-packages/starlette/routing.py", line 590, in __call__
api_1  |     await route(scope, receive, send)
api_1  |   File "/usr/local/lib/python3.7/site-packages/starlette/routing.py", line 208, in __call__
api_1  |     await self.app(scope, receive, send)
api_1  |   File "/usr/local/lib/python3.7/site-packages/starlette/routing.py", line 44, in app
api_1  |     await response(scope, receive, send)
api_1  |   File "./partial.py", line 88, in __call__
api_1  |     raise RuntimeError(f"File at path {self.path} does not exist.")
api_1  | RuntimeError: File at path /app/videos/train.mp4 does not exist.
api_1  | INFO: ('192.168.48.1', 33758) - "GET /projects HTTP/1.1" 200
api_1  | INFO: ('192.168.48.1', 33758) - "GET /external.csv HTTP/1.1" 200
api_1  | INFO: ('192.168.48.1', 33758) - "GET /videos/train.mp4 HTTP/1.1" 500
api_1  | ERROR: Exception in ASGI application
api_1  | Traceback (most recent call last):
api_1  |   File "/usr/local/lib/python3.7/site-packages/uvicorn/protocols/http/httptools_impl.py", line 375, in run_asgi
api_1  |     result = await app(self.scope, self.receive, self.send)
api_1  |   File "/usr/local/lib/python3.7/site-packages/fastapi/applications.py", line 140, in __call__
api_1  |     await super().__call__(scope, receive, send)
api_1  |   File "/usr/local/lib/python3.7/site-packages/starlette/applications.py", line 134, in __call__
api_1  |     await self.error_middleware(scope, receive, send)
api_1  |   File "/usr/local/lib/python3.7/site-packages/starlette/middleware/errors.py", line 178, in __call__
api_1  |     raise exc from None
api_1  |   File "/usr/local/lib/python3.7/site-packages/starlette/middleware/errors.py", line 156, in __call__
api_1  |     await self.app(scope, receive, _send)
api_1  |   File "/usr/local/lib/python3.7/site-packages/starlette/exceptions.py", line 73, in __call__
api_1  |     raise exc from None
api_1  |   File "/usr/local/lib/python3.7/site-packages/starlette/exceptions.py", line 62, in __call__
api_1  |     await self.app(scope, receive, sender)
api_1  |   File "/usr/local/lib/python3.7/site-packages/starlette/routing.py", line 590, in __call__
api_1  |     await route(scope, receive, send)
api_1  |   File "/usr/local/lib/python3.7/site-packages/starlette/routing.py", line 208, in __call__
api_1  |     await self.app(scope, receive, send)
api_1  |   File "/usr/local/lib/python3.7/site-packages/starlette/routing.py", line 44, in app
api_1  |     await response(scope, receive, send)
api_1  |   File "./partial.py", line 88, in __call__
api_1  |     raise RuntimeError(f"File at path {self.path} does not exist.")
api_1  | RuntimeError: File at path /app/videos/train.mp4 does not exist.
api_1  | ffmpeg version 3.4.6 Copyright (c) 2000-2019 the FFmpeg developers
api_1  |   built with gcc 6.4.0 (Alpine 6.4.0)
api_1  |   configuration: --prefix=/usr --enable-avresample --enable-avfilter --enable-gnutls --enable-gpl --enable-libass --enable-libmp3lame --enable-libvorbis --enable-libvpx --enable-libxvid --enable-libx264 --enable-libx265 --enable-libtheora --enable-libv4l2 --enable-postproc --enable-pic --enable-pthreads --enable-shared --enable-libxcb --disable-stripping --disable-static --disable-librtmp --enable-vaapi --enable-vdpau --enable-libopus --disable-debug
api_1  |   libavutil      55. 78.100 / 55. 78.100
api_1  |   libavcodec     57.107.100 / 57.107.100
api_1  |   libavformat    57. 83.100 / 57. 83.100
api_1  |   libavdevice    57. 10.100 / 57. 10.100
api_1  |   libavfilter     6.107.100 /  6.107.100
api_1  |   libavresample   3.  7.  0 /  3.  7.  0
api_1  |   libswscale      4.  8.100 /  4.  8.100
api_1  |   libswresample   2.  9.100 /  2.  9.100
api_1  |   libpostproc    54.  7.100 / 54.  7.100
api_1  | [concat @ 0x7fa6be03d460] Impossible to open '/app/http://commondatastorage.googleapis.com/gtv-videos-bucket/sample/BigBuckBunny.mp4'
api_1  | /app/dist/edl.edl: No such file or directory
api_1  | INFO: ('192.168.48.1', 33762) - "GET /render?edl=external.csv HTTP/1.1" 200
api_1  | INFO: ('192.168.48.1', 33762) - "GET /download?filename=external.csv.mp4 HTTP/1.1" 500
api_1  | ERROR: Exception in ASGI application
api_1  | Traceback (most recent call last):
api_1  |   File "/usr/local/lib/python3.7/site-packages/uvicorn/protocols/http/httptools_impl.py", line 375, in run_asgi
api_1  |     result = await app(self.scope, self.receive, self.send)
api_1  |   File "/usr/local/lib/python3.7/site-packages/fastapi/applications.py", line 140, in __call__
api_1  |     await super().__call__(scope, receive, send)
api_1  |   File "/usr/local/lib/python3.7/site-packages/starlette/applications.py", line 134, in __call__
api_1  |     await self.error_middleware(scope, receive, send)
api_1  |   File "/usr/local/lib/python3.7/site-packages/starlette/middleware/errors.py", line 178, in __call__
api_1  |     raise exc from None
api_1  |   File "/usr/local/lib/python3.7/site-packages/starlette/middleware/errors.py", line 156, in __call__
api_1  |     await self.app(scope, receive, _send)
api_1  |   File "/usr/local/lib/python3.7/site-packages/starlette/exceptions.py", line 73, in __call__
api_1  |     raise exc from None
api_1  |   File "/usr/local/lib/python3.7/site-packages/starlette/exceptions.py", line 62, in __call__
api_1  |     await self.app(scope, receive, sender)
api_1  |   File "/usr/local/lib/python3.7/site-packages/starlette/routing.py", line 590, in __call__
api_1  |     await route(scope, receive, send)
api_1  |   File "/usr/local/lib/python3.7/site-packages/starlette/routing.py", line 208, in __call__
api_1  |     await self.app(scope, receive, send)
api_1  |   File "/usr/local/lib/python3.7/site-packages/starlette/routing.py", line 44, in app
api_1  |     await response(scope, receive, send)
api_1  |   File "/usr/local/lib/python3.7/site-packages/starlette/responses.py", line 253, in __call__
api_1  |     raise RuntimeError(f"File at path {self.path} does not exist.")
api_1  | RuntimeError: File at path videos/external.csv.mp4 does not exist.```

normakster

No merge conflicts and it adds the functionality. We will need to open some issues around error handling of missing files.

Runs on Windows and Firefox.

mrharpo · 2020-03-07T07:21:52Z

Sample files can be downloaded with ./alfred demo.

Maybe we tie this in during ./alfred install? The wget -N option skips existing media already, so we're safe to re run it without re downloading files.

mrharpo added 30 commits February 20, 2020 12:35

changed /timeline to /editor

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

f7f237e

rewrote test to match demo

203c872

moved Project and Tools below Monitor, styled accordingly

6b835b5

added alertify messages on render!

5e51431

changed default scale

c4babda

changed scale slider initial position

f7b7677

added zoom in/out icons to Scale bar!

74bdf86

added initial TimelineTools!! #13 #21

5aa882c

added time selector tool, and set icon width

db4ce9f

fix for parcel bug in production

837149b

added svg cursor tools! #13 #21

6f9701c

fix for production bug

0cf23ff

expanded filter for tool events!

8d1f627

migrated to state.tool()

408c6c3

added trim tool

ecf9e52

changed fallback move cursor to -webkit-grab

48706cc

added title text to tools

34343bb

added cursorChecker for trim tool

b1a05f9

default 'time' tool

7d25592

massively simplified sortable filter!

375a4a9

moved edit functionality inside 'trim' tool

760e809

moved seek to inside 'time' tool

10bc363

partially working 'cut' tool!

6b7f90e

changed 'canplay' listener to 'loadeddata'

13ecc5d

moved l/r arrow listeners to Monitor

27f90d6

moved Project below Timeline

781b5c0

simplified Slider math

aadec10

migrated to using Number

2b98bc2

fixed time compare

1eed93c

fixed sortable clip duplication!!

ce5cd0e

mrharpo added 2 commits February 27, 2020 17:41

fixed icon style to normal

305f2e8

fixed 'cut' tool!!! closes #13, closes #21

b71aa83

mrharpo requested review from subcontrabass and normakster February 28, 2020 02:00

changed wget -nc to -N, fixes #28

621537a

mrharpo added 9 commits March 2, 2020 23:52

added placeholders for rest of alpha timeline tools!

de3cdd9

added slip tool functionality!!!

12a51b2

automated duration calculation!!

42ea829

working slide tool!!!

1b4cbb8

simplified trim logic

5896a4e

working dual roller tool!!!

66cca10

removed pointer-events on clip properties

29bb464

fixed cursorChecker!

a0860fd

updated tools in readme

f95ee86

mrharpo added 3 commits March 5, 2020 16:58

added multiDrag!! Closes #29

1c01610

added invertSwap for more natural overlap on resorting

017dd1d

added download functionaltiy to render button!!

6269ad2

mrharpo and others added 2 commits March 6, 2020 00:01

split render and download functions!

8839761

adjusted stability on start

21abddb

normakster approved these changes Mar 6, 2020

View reviewed changes

subcontrabass approved these changes Mar 9, 2020

View reviewed changes

mrharpo merged commit 92a87d2 into master Mar 9, 2020

mrharpo mentioned this pull request Mar 9, 2020

Actions: resize and seek #5

Closed

mrharpo deleted the tools branch June 27, 2020 00:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Tools #27

Tools #27

mrharpo commented Feb 28, 2020

Uh oh!

normakster commented Feb 29, 2020

Uh oh!

mrharpo commented Mar 6, 2020

Uh oh!

mrharpo commented Mar 6, 2020

Uh oh!

normakster commented Mar 6, 2020

Uh oh!

normakster commented Mar 6, 2020 •

edited

Loading

Uh oh!

normakster left a comment

Uh oh!

mrharpo commented Mar 7, 2020

Uh oh!

Tools #27

Tools #27

Conversation

mrharpo commented Feb 28, 2020

Uh oh!

normakster commented Feb 29, 2020

Uh oh!

mrharpo commented Mar 6, 2020

Uh oh!

mrharpo commented Mar 6, 2020

Uh oh!

normakster commented Mar 6, 2020

Uh oh!

normakster commented Mar 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

normakster left a comment

Choose a reason for hiding this comment

Uh oh!

mrharpo commented Mar 7, 2020

Uh oh!

normakster commented Mar 6, 2020 •

edited

Loading