-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
panlint: Add option to ignore missing inclusion of components/config #225
Conversation
@stdweird have a look |
What's the use case for this? |
I find the So far I've mostly ignored the message but now we have Jenkins that is not happy because of it. This allows a way to get around it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"whitelist" is not inclusive language - can you please rename all instances of it in this code? Given that it's really about ignoring a specific test, perhaps --ignore-missing-component-config would be a better name?
Although I also have concerns about this being a special case of a general issue, and a more configuration option would make sense?
Additionally, can you add tests for whatever you implement please. |
Looking good - can you please squash the commits and amend the commit message of 7c891c0? |
Panlint will not issue errors about the missing include for any component in the ignore list.
@ned21 good to go |
Approved. Do we have a plan to do a new release of panc to include the updated panlint? Or do we just recommend sites use it from HEAD? |
Sometime after the next general release yes, but I'd say using it from HEAD is fine too. |
Panlint will not issue errors about the missing include for any component in the whitelist.