Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

match("foo") throws an ugly exception #238

Merged
merged 1 commit into from
Jun 23, 2021
Merged

match("foo") throws an ugly exception #238

merged 1 commit into from
Jun 23, 2021

Conversation

gombasg
Copy link
Contributor

@gombasg gombasg commented Mar 10, 2020

No description provided.

@gombasg gombasg requested review from ned21 and jrha March 10, 2020 11:39
jrha
jrha previously approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@jrha jrha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, commit message could do with some explanatory text.

@jrha jrha added this to the 10.8 milestone Jun 23, 2021
@jrha jrha merged commit 66b8634 into quattor:master Jun 23, 2021
@jrha jrha mentioned this pull request Jan 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdweird stdweird stdweird left review comments

@jrha jrha jrha left review comments

@ned21 ned21 Awaiting requested review from ned21

Assignees
No one assigned
Labels
None yet
Milestone
10.8
Development

Successfully merging this pull request may close these issues.
3 participants
@gombasg @jrha @stdweird