Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clairctl: warn when server is not honoring range requests #2029

Closed
hdonnay opened this issue Apr 9, 2024 · 0 comments · Fixed by #2031
Closed

clairctl: warn when server is not honoring range requests #2029

hdonnay opened this issue Apr 9, 2024 · 0 comments · Fixed by #2031

Comments

@hdonnay
Copy link
Member

hdonnay commented Apr 9, 2024 •
edited
Loading

Do you think it would be possible to warn the user in case the range requests is not supported?

Originally posted by @freedge in #2022 (comment)
freedge added a commit to freedge/clair that referenced this issue Apr 10, 2024
@freedge
clairctl: warn when range requests are not honored
dc909e6 
As discussed in quay#2029 the manifest
generation is efficient only when HTTP "Range: bytes=0-0" header is well
supported by the server. If not, the server might return the full layer,
making the manifest generation very expensive.

We warn the user in case their HTTP server does not support HTTP range
requests.

Signed-off-by: François Rigault <frigo@amadeus.com>
@freedge freedge mentioned this issue Apr 10, 2024
Merged
hdonnay pushed a commit to freedge/clair that referenced this issue Apr 10, 2024
@freedge @hdonnay
clairctl: warn when range requests are not honored
13acc58 
As discussed in quay#2029 the manifest
generation is efficient only when HTTP "Range: bytes=0-0" header is well
supported by the server. If not, the server might return the full layer,
making the manifest generation very expensive.

We warn the user in case their HTTP server does not support HTTP range
requests.

Signed-off-by: François Rigault <frigo@amadeus.com>
@hdonnay hdonnay linked a pull request Apr 10, 2024 that will close this issue
clairctl: warn when range requests are not honored #2031
Merged
@hdonnay hdonnay closed this as completed Apr 10, 2024
crozzy pushed a commit to crozzy/clair that referenced this issue Apr 29, 2024
@freedge @crozzy
clairctl: warn when range requests are not honored
7e538bc 
As discussed in quay#2029 the manifest
generation is efficient only when HTTP "Range: bytes=0-0" header is well
supported by the server. If not, the server might return the full layer,
making the manifest generation very expensive.

We warn the user in case their HTTP server does not support HTTP range
requests.

Signed-off-by: François Rigault <frigo@amadeus.com>
@crozzy crozzy mentioned this issue Apr 29, 2024
Merged
crozzy pushed a commit that referenced this issue Apr 29, 2024
@freedge @crozzy
clairctl: warn when range requests are not honored
2a2ba37 
As discussed in #2029 the manifest
generation is efficient only when HTTP "Range: bytes=0-0" header is well
supported by the server. If not, the server might return the full layer,
making the manifest generation very expensive.

We warn the user in case their HTTP server does not support HTTP range
requests.

Signed-off-by: François Rigault <frigo@amadeus.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

clairctl: warn when range requests are not honored freedge/clair
1 participant
@hdonnay