clair: use fetcher defaults #2019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crozzy
approved these changes
Apr 9, 2024
hdonnay
force-pushed
the
hack/fetcher_default
branch
from
4f71e16
to
a22db79
Compare
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
Also reworks the formatting and some grammar. Signed-off-by: Hank Donnay <hdonnay@redhat.com>
hdonnay
force-pushed
the
hack/fetcher_default
branch
from
a22db79
to
137b6c5
Compare
crozzy
added a commit
to crozzy/clair
that referenced
this pull request
Apr 9, 2024
Since quay#2019 clair will now use /var/tmp instead of /tmp by default to store the manifest layers. This PR updates where the PVC is mounted in order to concide with the new default. Signed-off-by: crozzy <joseph.crosland@gmail.com>
crozzy
added a commit
to crozzy/clair
that referenced
this pull request
Apr 9, 2024
Since quay#2019 clair will now use /var/tmp instead of /tmp by default to store the manifest layers. This PR updates where the PVC is mounted in order to concide with the new default. Signed-off-by: crozzy <joseph.crosland@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since quay/claircore#1292 is merged, clair should get updated to actually use the added default logic. This change does that and adds a mention to the documentation.
Here's the new section rendered:
The rest of the documentation that I touched looks fine to me.
We could probably stand to add an explicit configuration option for this, but I'd want to consider how modular we expect the fetcher to be in Clair first.