Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: use Layer.FS method #1105

Merged
merged 15 commits into from
Oct 24, 2023
Merged

all: use Layer.FS method #1105

merged 15 commits into from
Oct 24, 2023

Conversation

hdonnay
Copy link
Member

@hdonnay hdonnay commented Oct 13, 2023

Doing this should allow us to realize potential memory savings enabled by #1061.

All the in-tree Scanner implementations should now share a single tarfs.FS instance per layer.

@hdonnay hdonnay requested a review from a team as a code owner October 13, 2023 21:36
@hdonnay hdonnay requested review from crozzy and removed request for a team October 13, 2023 21:36
@codecov
Copy link

codecov bot commented Oct 13, 2023 •
edited
Loading

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Files Coverage Δ
osrelease/scanner.go 73.64% <100.00%> (+1.09%) ⬆️
rhel/repositoryscanner.go 60.00% <100.00%> (+0.46%) ⬆️
whiteout/scanner.go 65.62% <100.00%> (+3.46%) ⬆️
apk/scanner.go 82.19% <50.00%> (+2.97%) ⬆️
debian/distributionscanner.go 21.66% <0.00%> (+1.66%) ⬆️
dpkg/distroless_scanner.go 58.75% <66.66%> (+1.10%) ⬆️
dpkg/scanner.go 72.93% <50.00%> (+0.59%) ⬆️
gobin/gobin.go 43.60% <50.00%> (+0.13%) ⬆️
java/packagescanner.go 34.65% <50.00%> (-0.13%) ⬇️
python/packagescanner.go 68.65% <50.00%> (+1.03%) ⬆️
... and 11 more

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@hdonnay hdonnay force-pushed the hack/use-fs-method branch 5 times, most recently from 8ab3aed to a8ac5ed Compare October 23, 2023 16:48
crozzy
crozzy previously approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@crozzy crozzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, needs-changelog?

dpkg/distroless_scanner.go Outdated Show resolved Hide resolved
@hdonnay hdonnay added the needs-changelog Label for PRs that need a changelog note. label Oct 24, 2023
hdonnay added 15 commits October 24, 2023 11:46
@hdonnay
alpine: use Layer.FS method
1d40fb7 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
apk: use Layer.FS method
c407559 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
debian: use Layer.FS method
ad87887 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
dpkg: use Layer.FS method
8b09503 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
gobin: use Layer.FS method
162c725 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
java: use Layer.FS method
477e090 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
osrelease: use Layer.FS method
bbb6077 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
python: use Layer.FS method
e02b273 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
rhel: use Layer.FS method
d4a64cf 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
rhcc: use Layer.FS method
7e0deeb 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
rpm: use Layer.FS method
53934e5 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
ruby: use Layer.FS method
4923605 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
pkgconfig: use Layer.FS method
612748f 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
ubuntu: use Layer.FS method
36f746a 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
whiteout: use Layer.FS method
ea418ab 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay hdonnay force-pushed the hack/use-fs-method branch from a8ac5ed to ea418ab Compare October 24, 2023 16:46
@hdonnay hdonnay requested a review from crozzy October 24, 2023 17:16
@hdonnay hdonnay merged commit ea418ab into quay:main Oct 24, 2023
@hdonnay hdonnay deleted the hack/use-fs-method branch October 24, 2023 17:19
@hdonnay hdonnay removed the needs-changelog Label for PRs that need a changelog note. label Oct 25, 2023
@hdonnay hdonnay mentioned this pull request Oct 26, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crozzy crozzy crozzy approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hdonnay @crozzy