Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(libindex): use different temp perms per OS #1137

Closed
wants to merge 1 commit into from
Closed

fix(libindex): use different temp perms per OS #1137

wants to merge 1 commit into from

Conversation

RTann
Copy link
Contributor

@RTann RTann commented Nov 7, 2023

ClairCore 1.5.20 did not build on macOS due to non-existent file perms. This PR aims to correct that.

@RTann
fix(libindex): use different temp perms per OS
9a09c76 
Signed-off-by: RTann <rtannenb@redhat.com>
@RTann RTann requested a review from a team as a code owner November 7, 2023 01:22
@RTann RTann requested review from hdonnay and removed request for a team November 7, 2023 01:22
@codecov Codecov
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
libindex/fetcher.go 72.31% <100.00%> (ø)
libindex/open_linux.go 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

@RTann RTann requested a review from crozzy November 7, 2023 05:08
@RTann
Copy link
Contributor Author

RTann commented Nov 7, 2023

This is not complete, as the fetcher reads from proc/self/fd/FD, which doesn't exist on Darwin. Instead it should be /dev/fd/FD (I think), but I keep getting a permission error, so I'm thinking this strategy may not work for darwin

@RTann
Copy link
Contributor Author

RTann commented Nov 7, 2023

closing this in favor of #1140

@RTann RTann closed this Nov 7, 2023
@RTann RTann deleted the openTemp-fetcher branch November 7, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdonnay hdonnay Awaiting requested review from hdonnay hdonnay is a code owner automatically assigned from quay/clair

@crozzy crozzy Awaiting requested review from crozzy

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RTann