integration: make PGVERSION a pattern
#1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO:
|
hdonnay
force-pushed
the
hack/CI-helpers
branch
from
7e1fe47
to
0d4fb6e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1147 +/- ##
==========================================
- Coverage 52.09% 52.06% -0.04%
==========================================
Files 220 220
Lines 16843 16843
==========================================
- Hits 8775 8769 -6
- Misses 7259 7264 +5
- Partials 809 810 +1 ☔ View full report in Codecov by Sentry. |
crozzy
previously approved these changes
Nov 17, 2023
hdonnay
force-pushed
the
hack/CI-helpers
branch
from
0d4fb6e
to
272a309
Compare
|
Needed to make changes after doing another bout of testing from a clean cache, so re-requesting review. |
This change makes it so that specifying a pattern like `latest` or `15` looks at the bill of materials for the embedded PostgreSQL binaries and fetches a matching version. Previously, this environment variable needed to be a full `<major>.<minor>.<patch>` version. That's still allowed if a specific version is needed. Signed-off-by: Hank Donnay <hdonnay@redhat.com>
hdonnay
force-pushed
the
hack/CI-helpers
branch
from
272a309
to
53a666f
Compare
crozzy
approved these changes
Dec 7, 2023
| t.Fatal(err) | ||
| } | ||
|
|
||
| // Open the jar (note a jar is just a zip with specific contents) and find |
|
/fast-forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1140 got me thinking about how the database harness works for not-Linux, so I took a look.
Turns out the project that builds the binaries has added more architectures in the meantime,
so I reworked things to not pin versions as aggressively and support the current suite of OS + architecture.
This change makes it so that specifying a pattern like
latestor15looks at the bill of materials for the embedded PostgreSQL binaries and fetches a matching version. Previously, this environment variable needed to be a full<major>.<minor>.<patch>version. That's still allowed if a specific version is needed.