Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed podman commands and added additional hint #43

Merged
merged 3 commits into from
Feb 21, 2022
Merged

fixed podman commands and added additional hint #43

merged 3 commits into from
Feb 21, 2022

Conversation

zisisli
Copy link
Contributor

@zisisli zisisli commented Jan 20, 2022

  • port 8080 -> 8443
  • added podman pull image before tagging
  • added hint about creating a repository before pushing image

@zisisli
fixed podman commands and added additional hint
63f940a 
* port 8080 -> 8443
* added podman pull image before tagging
* added hint about creating a repository before pushing image
@zisisli
Merge branch 'main' into main
a2eeb5c
HammerMeetNail
HammerMeetNail requested changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@HammerMeetNail HammerMeetNail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zisisli Thanks for getting this in. Can you reword line 89 and we'll get this merged? It would be nice to let people know this is only temporary and future versions will automatically create repositories on push. Maybe something like:

Prior to pushing quay:8443/init/busybox, you must create the repository "busybox" in the Quay console. In future versions of mirror registry this will be created automatically.

@zisisli
Copy link
Contributor Author

zisisli commented Feb 18, 2022

@zisisli Thanks for getting this in. Can you reword line 89 and we'll get this merged? It would be nice to let people know this is only temporary and future versions will automatically create repositories on push. Maybe something like:

Prior to pushing quay:8443/init/busybox, you must create the repository "busybox" in the Quay console. In future versions of mirror registry this will be created automatically.

done.

HammerMeetNail
HammerMeetNail approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@HammerMeetNail HammerMeetNail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@HammerMeetNail HammerMeetNail merged commit 9692bcc into quay:main Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammerMeetNail HammerMeetNail HammerMeetNail approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zisisli @HammerMeetNail