Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: adding tag_pattern to autoprune API (PROJQUAY-7668) #3188

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

bcaton85
Copy link
Contributor

@bcaton85 bcaton85 commented Sep 3, 2024

Allows users to specify a regex tag pattern when creating namespace/repository autoprune policies via the new UI. Users will have the option to prune tags that only match the tag pattern or exclude tags that match the tag pattern.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 83.92857% with 9 lines in your changes missing coverage. Please review.

Project coverage is 70.45%. Comparing base (40499d8) to head (cea1fcc).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
data/model/autoprune.py 52.94% 4 Missing and 4 partials ⚠️
data/text.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3188      +/-   ##
==========================================
+ Coverage   70.43%   70.45%   +0.01%     
==========================================
  Files         440      440              
  Lines       41603    41660      +57     
  Branches     5463     5481      +18     
==========================================
+ Hits        29303    29350      +47     
- Misses      10572    10579       +7     
- Partials     1728     1731       +3     
Flag Coverage Δ
unit 70.45% <83.92%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

data/text.py Show resolved Hide resolved
data/model/oci/tag.py Show resolved Hide resolved
Copy link
Contributor

@Sunandadadi Sunandadadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bcaton85 bcaton85 merged commit 6da65c5 into quay:master Sep 13, 2024
19 checks passed
sayalibhavsar pushed a commit to sayalibhavsar/myquay that referenced this pull request Sep 18, 2024
Allows users to specify a regex tag pattern when creating namespace/repository autoprune policies via the new UI. Users will have the option to prune tags that only match the tag pattern or exclude tags that match the tag pattern.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants