fixes #175. utf-8 errors in Python 3. #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pping multibyte utf-8 sequences in half
|
This patch is great, thanks! Who should we assign it to in order to merge it into master? |
|
Hey Hey is anyone is still trying to get it in, this fixed solved a problem I was having with the SDK and I would love to see it in SDK. |
|
Thanks for the patch. Merged into unreleased branch for now, which will be picked up in the next release and master branch as well. |
chattarajoy
pushed a commit
that referenced
this pull request
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by block reads chopping multibyte utf-8 sequences in half
Because of the 8192 bytes read block size, a utf-8 character can possibly be cut in two, causing the block to be invalid utf-8.
Fixed by not decoding the block. Instead encode the delimiter and do the replace operation with bytes instead of str.