Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix or skip deepsource check in commands.py #341

Closed
wants to merge 34 commits into from
Closed

Fix or skip deepsource check in commands.py #341

wants to merge 34 commits into from

Conversation

winebarrel
Copy link

@winebarrel winebarrel commented Oct 15, 2023 •
edited
Loading

Fix or skip deepsource check in commands.py.
see https://app.deepsource.com/gh/qubole/qds-sdk-py/run/3a681a44-90cc-4531-852d-1e410a2f9854/python/

skip list:

  • PTC-W0065: Unused nested function or class detected
  • PY-D0002: Missing class docstring
  • PY-D0003: Missing module/function docstring
  • PYL-C0209: Consider using f-strings
  • PYL-W0402: Use of a deprecated module detected
  • PY-R1000
  • PYL-W0511 Use of FIXME/XXX/TODO encountered

and set max_line_length = 200 for FLK-E501 c02e4e9

@winebarrel winebarrel marked this pull request as draft October 15, 2023 14:33
@winebarrel winebarrel force-pushed the fix_for_deepsource branch 3 times, most recently from 0e70566 to e484cc6 Compare October 15, 2023 15:10
@winebarrel winebarrel marked this pull request as ready for review October 15, 2023 15:56
@winebarrel winebarrel closed this Aug 12, 2024
@winebarrel winebarrel deleted the fix_for_deepsource branch August 12, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@winebarrel