Bundler-agnostic CommonJS using prepublish script #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmelnikow
changed the title
Closed
|
Can you rebase this on master please? Looks like some of the previous PR got into this. |
|
I think I might have a slightly leaner solution to this, which will come with the added benefits of a UMD module. Would you mind if I put together a PR for that and see what you think? |
Remove dependency on brfs and add Webpack support. Closes #3
|
Closing in favor of #8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dependency on brfs and add Webpack support.
It's a little tricky to test a package with a prepublish script without actually publishing it. I used
npm packand then uncompressed the file, and my Node-based tests work fine. Do you have an easy way to test the browser version? I'll work on adding browser-based tests next.Depends on #4