Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build #23

Merged
merged 4 commits into from
Nov 16, 2017
Merged

Build #23

merged 4 commits into from
Nov 16, 2017

Conversation

TrySound
Copy link
Contributor

@TrySound TrySound commented Nov 1, 2017

Tests are still fails, not sure why
Es dist doesn't make sense for bower

@TrySound
Copy link
Contributor Author

TrySound commented Nov 1, 2017

Also jsnext:main field is not used anymore.

@que-etc que-etc merged commit a78dd88 into que-etc:master Nov 16, 2017
@TrySound TrySound deleted the build branch November 16, 2017 15:16
@que-etc
Copy link
Owner

que-etc commented Nov 16, 2017

@TrySound

Thank you so much for all these pull requests! I really appreciate it and I'm sorry for making you wait so long (been preoccupied with the ordeal of an immigration process).

As for the build fails, I'll add an extra case for pull requests that will run tests in Firefox instead of connecting to Sauce Labs (#26).

@TrySound
Copy link
Contributor Author

Thanks to you for this project.

@TrySound
Copy link
Contributor Author

Hope to see release with types soon.:)

@que-etc
Copy link
Owner

que-etc commented Nov 16, 2017

Working on it right now )

I just wanna ship it with fixes for some of the pending issues. Pretty sure that it will be out today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants