-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention Active Job integration in the README #231
Conversation
Hey there!
|
Hi! It seems we are already on the new repository: #231 Doesn't it work the way it is now? |
Yeah forget my comment, we first forked the repository but then decided to transfer it to the organization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My opinion (and goal) on this for que 1.0:
- We should provide a rails generator to install que, something like
rails g que:install
which should generate the migration and change the active record dump tostructure.sql
. - We should have clear documentation paths what's rails specific and what's not.
(Just a general notice for myself here) 😄
README.md
Outdated
ActiveJob::Base.queue_adapter = :que | ||
``` | ||
|
||
Que will automatically pick up the database from Active Record, so there is no need to configure anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you mean Active Job
, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I read this part of the code I thought the database connection was managed by Active Record. In fact I think you can use Que with Active Record without using Active Job at all, but I might be wrong.
Does that make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. Now I get it. This says that que
will automatically use the Active Record connection.
I think the pick up
is confusing. Can we use something like:
Que will automatically use the database configuration of your rails application.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Anything else?
Co-Authored-By: Yves Siegrist <Elektron1c97@gmail.com>
@giovannibonetti Maybe you missed my feedback on the second part. So see this message as a friendly "ping", because I'm really looking forward to have this in the README! |
All right, I didn't notice that part. I will change it now. 👍 |
I'm not a native english speaker, so if you disagree, feel free to keep it as is. |
I'm not either, but your suggestion looks good, so I think it is worth the change! 👍 |
Thanks for your contribution! 💚 |
You're welcome! 😀 |
Thank you for this great library!
I've read the discussion on #127 and it seems like now there is great Active Job integration, so maybe it would be nice to document it so that new users can easily find it and decide to use it.
It took me a while to find this library because it is not mentioned in the Rails Guides, even though it is mentioned in the API docs. It seems like the guides are more beginner-friendly and have links specific to the README section explaining how to integrate the library with Active Job. Hence if we have that section in the README we could have a link from Rails Guides pointing directly to it which would bring people here.
What do you think?