Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing Axios in favour of node-fetch #119

Closed
nickytonline opened this issue Oct 29, 2020 · 2 comments
Closed

Consider removing Axios in favour of node-fetch #119

nickytonline opened this issue Oct 29, 2020 · 2 comments
Labels
infrastructure Anything infrastructure related

Comments

@nickytonline
Copy link
Collaborator

nickytonline commented Oct 29, 2020 •
edited
Loading

fetch is not native in Node yet (I think they're working on it), but there is node-fetch.

It has a way smaller footprint than Axios and the extra stuff Axios provides is not required in the project from what I can tell. This change would also require pulling out the axios-mock-adapter package and replacing it with most likely jest-fetch-mock.

Documents and Links
@nickytonline nickytonline added the infrastructure Anything infrastructure related label Oct 29, 2020
@raae
Copy link
Member

raae commented Oct 29, 2020

I just really like working with Axios ;D

@nickytonline
Copy link
Collaborator Author

I'll close this then @raae.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infrastructure Anything infrastructure related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raae @nickytonline