Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep a local copy of the provider list #64

Closed
raae opened this issue May 15, 2019 · 4 comments
Closed

Keep a local copy of the provider list #64

raae opened this issue May 15, 2019 · 4 comments

Comments

@raae
Copy link
Member

raae commented May 15, 2019

I do not have any reports of https://oembed.com/providers.json not responding, but it could be nice to have a local copy to fall back if that happens.

It could be cool if the file was downloaded and added to the project on every npm publish or something automatic like that to keep it as current as possible.
@raae
Copy link
Member Author

raae commented May 30, 2019

This might be something for you @testower.

@testower
Copy link
Collaborator

Cool I'll have a look @raae

testower added a commit that referenced this issue May 30, 2019
@testower
feature: Keep a local copy of the provider list - solves #64
e5dc2e3 
Prefetch provider list when publishing package. If fetching fails when plugin runs, use the prefetched list instead.
raae pushed a commit that referenced this issue Jun 3, 2019
@testower @raae
✨ Keep a local copy of the provider list - solves #64 (#71)
eb8630a 
Prefetch provider list when publishing the package. If fetching fails when plugin runs, use the prefetched list instead.
@testower
Copy link
Collaborator

Did you try this yet @raae ?

@raae
Copy link
Member Author

raae commented Jun 19, 2019

Yes and merged!

@raae raae closed this as completed Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@testower @raae