OpenLayers 5

[samuel-girard]

Hi,
I'm working on the integration with OpenLayers 5.
All the work will be done on this branch.

Hope to have something to show within the next few days.

[davinkevin]

Can you rebase it on the branch next ?

[samuel-girard]

Hello
I just rebased it on next branch

[davinkevin]

I still have the change done by @Neonox31 in the pull request which is not coherent with a rebase upon next branches. Could you check it?

BTW, I've seen a lot of style modification in your code (mainly around the @input on two line instead of one). Could you follow what has already be done to simplify the merge request. As is, it seems to be too many modification to still be clear.

Thanks

[samuel-girard]

OK, I previously only rebased the branch, but not the PR.
It is OK now, you shouldn't see any more of these style modifications.

For information, this is not yet ready to be merged: it is working well as it is (no issue found so far), but it lacks of OpenLayers typings. I temporarily created an ol-models to workaround this problem.
There is a big work beeing done in OpenLayers for that, so I hopefully can fix this soon.

[FallenRiteMonk]

what is the status of this?

[samuel-girard]

Hello,
Updated after the release of OpenLayers 5.3, this branch can now be merged.
There are still typings issues: for example your IDE will not offer you autocompletion for OpenLayers types used inside your application, but at least, ngx-openlayers will not fail to compile.

There is a workaround for the autocompletion if it is a big issue: openlayers/openlayers#8448 (comment)

[samuel-girard]

Hi @Neonox31
I rebased this branch on next. You can merge it.
Thanks

[HarelM]

Any updates on this? It would really help to have ol 5 in next branch and pre-released to npm.

[Yakoust]

@kekel87 @davinkevin @Neonox31 @dabbid could you please have a look on this PR?

[kekel87]

There are still openlayers imports in attribution.component.ts and attributions.component.ts.

[Yakoust]

@samuel-girard are you available to debate/resolve discussions?

[samuel-girard]

Hello @Yakoust
Thanks for your feedback on this PR.
I quickly had a look at your points and it seems good to me, although I haven't checked everything in details.
Unfortunately, I will not have time to apply the changes so I will be thankful if someone here could take care of it.

[Yakoust]

There are still openlayers imports in attribution.component.ts and attributions.component.ts.

I also export those components in module. There were missing

[Yakoust]

Thanks @remiHau for your comment on #225
OL 5 version has changed to 5.3.1 in this PR