Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: render modal inside the body #101

Merged
merged 1 commit into from
Aug 11, 2023
Merged

refactor: render modal inside the body #101

merged 1 commit into from
Aug 11, 2023

Conversation

sudeepmahato16
Copy link
Contributor

I have used createPortal to render the modal directly within the body element.

Resolves #98

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@invisal invisal self-requested a review August 11, 2023 07:23
invisal
invisal approved these changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@invisal invisal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@invisal invisal changed the title Render modal inside the body refactor: render modal inside the body Aug 11, 2023
@invisal invisal merged commit f23068f into querymx:main Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invisal invisal invisal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using createPortal for modal
2 participants
@sudeepmahato16 @invisal