Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use pinentry-mac as pinentry binary on macOS for approvals #300

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

Oisann
Copy link
Contributor

@Oisann Oisann commented Oct 28, 2024

I couldn't approve SSH Agent requests on macOS, it would just automatically deny any request.
This seems to be fixing the issue.

@Oisann
Copy link
Contributor Author

Oisann commented Oct 28, 2024

I didn't really look into it yet, but I also had issues building locally. I get a binary that just dies, but the same commit produced a working binary using Github Actions on my fork (macOS arm64). Am I missing something obvious?

@quexten
Copy link
Owner

quexten commented Oct 30, 2024

Any errors when it dies?

@quexten
Copy link
Owner

quexten commented Oct 30, 2024

Either way, changes look good, thank you!

@quexten quexten merged commit b62ffb2 into quexten:main Oct 30, 2024
10 of 11 checks passed
@Oisann
Copy link
Contributor Author

Oisann commented Oct 31, 2024

Any errors when it dies?

jonas@Jonas-MBP-M2 ~/Development/goldwarden (oisann/macos-ssh-agent-pinentry-fix) % go build -v .
github.com/quexten/goldwarden/cli/agent/systemauth/pinentry
github.com/quexten/goldwarden
jonas@Jonas-MBP-M2 ~/Development/goldwarden (oisann/macos-ssh-agent-pinentry-fix) % ls -lAh
total 26416
drwxr-xr-x@ 17 jonas  staff   544B Oct 31 09:31 .git
drwxr-xr-x@  5 jonas  staff   160B Oct 28 13:24 .github
-rw-r--r--@  1 jonas  staff   101B Oct 28 13:24 .gitignore
-rw-r--r--@  1 jonas  staff   1.0K Oct 28 13:24 LICENSE
-rw-r--r--@  1 jonas  staff   3.2K Oct 28 13:24 Readme.md
drwxr-xr-x@ 10 jonas  staff   320B Oct 28 13:24 cli
-rw-r--r--@  1 jonas  staff   2.4K Oct 28 13:24 go.mod
-rw-r--r--@  1 jonas  staff    12K Oct 28 13:24 go.sum
-rwxr-xr-x@  1 jonas  staff    13M Oct 31 09:31 goldwarden
drwxr-xr-x@ 12 jonas  staff   384B Oct 28 13:24 gui
-rw-r--r--@  1 jonas  staff   1.9K Oct 28 13:24 main.go
jonas@Jonas-MBP-M2 ~/Development/goldwarden (oisann/macos-ssh-agent-pinentry-fix) % ./goldwarden
zsh: killed     ./goldwarden
jonas@Jonas-MBP-M2 ~/Development/goldwarden (oisann/macos-ssh-agent-pinentry-fix) % echo $?
137

@Oisann Oisann deleted the oisann/macos-ssh-agent-pinentry-fix branch November 4, 2024 19:38
@Oisann
Copy link
Contributor Author

Oisann commented Nov 29, 2024

I found my local issue. It's a bug on arm macs with certain go versions (I think from 1.21, I used 1.22.2) and updating to 1.23.3 fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants