http3: initialize trailer map with empty trailer entries when parsing the header #4656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4656 +/- ##
==========================================
+ Coverage 84.88% 84.90% +0.01%
==========================================
Files 150 150
Lines 14918 14930 +12
==========================================
+ Hits 12663 12675 +12
Misses 1727 1727
Partials 528 528 ☔ View full report in Codecov by Sentry. |
marten-seemann
requested changes
Sep 4, 2024
marten-seemann
changed the title
|
@sudorandom I just merged #4630. Can you rebase this PR? |
sudorandom
force-pushed
the
trailer-header
branch
from
ac8ffbd to
7d37ded
Compare
Yep, rebased! |
marten-seemann
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #4654
This RP changes the client logic to prepopulates
Response.Trailerusing the trailers defined in the "Trailer" header and then removes the trailer header, like net/http does.This is based off of #4630, so only the last few commits are unique.