Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward port recipes required for generating machine specific partitioning files #67

Merged
merged 6 commits into from
Nov 15, 2024

Conversation

ricardosalveti
Copy link
Contributor

Forward port from kirkstone (qclinux 1.2) the recipes required for generating machine specific partitioning files.

This is enough to have a working partition.xml and respective rawprogram/patch .xml files.

@ndechesne
Copy link
Contributor

a few minor comments, but overall it is probably ok to reuse from QCL 1.x. However, we also talked about having a standalone project for building/maintaining such boot files. Given that all tools needed are OSS, we could host it on github. At Linaro we had that https://git.codelinaro.org/linaro/qcomlt/db-boot-tools which is where they maintain board specific partition config files, and generates all artefact needed (rawprogram files, ...). The main advantage to have them outside of QC Linux is that it becomes indepedent of the target distro.

Copy link
Contributor

@quaresmajose quaresmajose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

none of these recipes use the toolchain and so we can skip it with INHIBIT_DEFAULT_DEPS in all of them. tested locally

+INHIBIT_DEFAULT_DEPS = "1"

@ricardosalveti
Copy link
Contributor Author

a few minor comments, but overall it is probably ok to reuse from QCL 1.x. However, we also talked about having a standalone project for building/maintaining such boot files. Given that all tools needed are OSS, we could host it on github. At Linaro we had that https://git.codelinaro.org/linaro/qcomlt/db-boot-tools which is where they maintain board specific partition config files, and generates all artefact needed (rawprogram files, ...). The main advantage to have them outside of QC Linux is that it becomes indepedent of the target distro.

Yes, created #69 so we can track this separately.

This layer should consume and produce all the final files required for a full flash, but we should maintain the files (partition.conf) and related data in a common repository, and have meta-qcom-hwe consume from it instead.

@ricardosalveti
Copy link
Contributor Author

@quaresmajose @ndechesne updated based on the review comments.

@ndechesne ndechesne self-requested a review November 14, 2024 05:38
Recipe based on kirkstone rev 3ac146c (qclinux 1.2), needed by
qcom-partition-confs, which is the recipe responsible for generating the
machine partition configuration.

Signed-off-by: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com>
Recipe based on kirkstone rev 3ac146c (qclinux 1.2), used to generate the
machine specific partition binary files out of partition.xml.

Patches also from qclinux 1.2, which should ideally just be proposed
upstream instead, but discussion pending if the target repository should
indeed be used as upstream.

Signed-off-by: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com>
Recipe based on kirkstone rev 3ac146c (qclinux 1.2), used to generate the
machine specific partition.xml file which is later converted to binary with
help from ptool.py.

Partition confs for qcm6490 and qcs9100 modified to remove persist and
overlay, and instead use a larger system/rootfs partition, since that
should really be a distro decision and not a BSP one.

Signed-off-by: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com>
Recipe based on kirkstone rev 3ac146c (qclinux 1.2), used to generate the
machine specific partition binaries, required for flashing with qdl.

Signed-off-by: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com>
Add qcom-gen-partition-bins to EXTRA_IMAGEDEPENDS in order to build and
deploy all the machine specific partition binaries which are required
for flashing the device.

Signed-off-by: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com>
Add qcom-gen-partition-bins to EXTRA_IMAGEDEPENDS in order to build and
deploy all the machine specific partition binaries which are required
for flashing the device.

Signed-off-by: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com>
@quic-vkraleti quic-vkraleti merged commit deba7a2 into quic-yocto:main Nov 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants