fix the encoding.csv file lacation to the right diractory #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aiwhz This looks like an obvious fix to me but I think you need to add the "Signed-Off-By" tag to your commit. For details you can check out the "Details" link in this PR. And as you have to force-push anyway maybe you can also fix the spelling errors in your commit description ("lacation", "diractory"). |
quic-bharathr
approved these changes
Oct 11, 2023
|
This is done in another PR: #45 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path of the encoding.csv now uses a relative path, which is not correct, and cannot find the downloaded encoding.csv.
We can use the self.model_name_or_path, which is initialized with the right absolute path correctly.