Fix onnx torch dependency #3567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o OFF when building aimet w/ onnx variant Signed-off-by: Trentin Wilkens <quic_twilkens@quicinc.com>
Signed-off-by: Trentin Wilkens <quic_twilkens@quicinc.com>
…e readable Signed-off-by: Trentin Wilkens <quic_twilkens@quicinc.com>
Signed-off-by: Trentin Wilkens <quic_twilkens@quicinc.com>
Signed-off-by: Trentin Wilkens <quic_twilkens@quicinc.com>
quic-twilkens
requested review from
quic-bharathr,
quic-akhobare and
quic-kyunggeu
quic-akhobare
approved these changes
Dec 7, 2024
quic-bharathr
approved these changes
Dec 7, 2024
quic-twilkens
added a commit
that referenced
this pull request
Dec 10, 2024
…ants (#3567) * removed unnecessary && condition that did not default DENABLE_TORCH to OFF when building aimet w/ onnx variant * edited comments of docker_install.md to add clarity * shortened docker build extra_opts if statements to be shorter and more readable * fixed if statment nesting * fixed typo in torch variant extra_opts concatenation Signed-off-by: Trentin Wilkens <quic_twilkens@quicinc.com>
quic-twilkens
added a commit
that referenced
this pull request
Dec 10, 2024
…ants (#3567) * removed unnecessary && condition that did not default DENABLE_TORCH to OFF when building aimet w/ onnx variant * edited comments of docker_install.md to add clarity * shortened docker build extra_opts if statements to be shorter and more readable * fixed if statment nesting * fixed typo in torch variant extra_opts concatenation Signed-off-by: Trentin Wilkens <quic_twilkens@quicinc.com>
quic-bharathr
pushed a commit
that referenced
this pull request
Dec 20, 2024
…ants (#3567) * removed unnecessary && condition that did not default DENABLE_TORCH to OFF when building aimet w/ onnx variant * edited comments of docker_install.md to add clarity * shortened docker build extra_opts if statements to be shorter and more readable * fixed if statment nesting * fixed typo in torch variant extra_opts concatenation Signed-off-by: Trentin Wilkens <quic_twilkens@quicinc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.