[QEff Finetune]: Use logger in place of print statements in finetuning scripts #371
+117
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quic-mamta
requested review from
quic-swatia and
vbaddi
and removed request for
ochougul and
quic-rishinr
Signed-off-by: Mamta Singh <quic_mamtsing@quicinc.com>
Signed-off-by: Mamta Singh <168400541+quic-mamta@users.noreply.github.com>
quic-meetkuma
suggested changes
May 12, 2025
| @@ -63,6 +65,6 @@ def get_data_collator(dataset_processer, dataset_config): | |||
| try: | |||
| return getattr(module, func_name)(dataset_processer) | |||
| except AttributeError: | |||
There was a problem hiding this comment.
This is for all the cases like L62.
Whenever we are raising some exceptions, it is good to log the raised exception, otherwise dumped file logs would represent different picture than the console logs.
We can override the logger to have a custom log function as below.
import logging
class CustomLogger(logging.Logger):
def raise_runtimeerror(self, message):
self.error(message)
raise RuntimeError(message)
logging.setLoggerClass(CustomLogger)
logger = logging.getLogger(__name__)
logging.basicConfig(level=logging.DEBUG, filename='app.log', filemode='a',
format='%(asctime)s - %(name)s - %(levelname)s - %(message)s')
What do you say?
quic-meetkuma
suggested changes
May 12, 2025
| @@ -113,26 +114,26 @@ def train( | |||
| for epoch in range(train_config.num_epochs): | |||
| if loss_0_counter.item() == train_config.convergence_counter: | |||
| if train_config.enable_ddp: | |||
| print( | |||
| logger.info( | |||
There was a problem hiding this comment.
One important change is required.
We need to log on console only for rank == 0 in case of ddp. Otherwise in 64x ddp or 48x ddp will fill the console with lot of information which is not user friendly.
Signed-off-by: Mamta Singh <mamtsing@blr-ubuntu-g293-22.qualcomm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use logger in place of print statements in finetuning scripts