IntelliJ inspections corrected and some dependencies updated. #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrjohn
reviewed
Jul 24, 2017
| clientApplication.setUpLogonExpectation(); | ||
|
|
||
| initiator.block(); | ||
| initiator.start(); |
There was a problem hiding this comment.
I think it does not make sense to change block() to start() here since the test specifically tests for block() (although test is ignored). Maybe mark it as deprecated so it can be cleaned up when the block() implementation is cleaned up.
There was a problem hiding this comment.
I have reverted this particular line, later on you can decide if to keep the test or remove it completely along with the block method.
guidomedina
force-pushed
the
intellij-inspections-corrected-and-some-deps-updated
branch
from
3487725 to
bfe5469
Compare
guidomedina
deleted the
intellij-inspections-corrected-and-some-deps-updated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IntelliJ inspections corrected and some dependencies updated.