Skip to content

Conversation

philipwhiuk
Copy link
Contributor

Remove some of the boilerplate in this test class.

@philipwhiuk
Copy link
Contributor Author

philipwhiuk commented Sep 18, 2017

SSLCertificateTest.shouldFailIndividualSessionsWhenInvalidCertificatesUsed:257 No SSL exception thrown

Odd. My code doesn't change that. Looks like it fails in master too though - @chrjohn ?

@chrjohn
Copy link
Member

chrjohn commented Sep 19, 2017

Hi @philipwhiuk ,
don't worry, the failing build has nothing to do with your changes. It is failing from time to time in the SSL-related tests. But I didn't get around to finding out why. I suspect it has to do with the SSLFilter. Will open a separate issue for that.
Thanks for the PR!
Cheers,
Chris.

@chrjohn chrjohn added this to the QFJ 2.0.0 milestone Sep 19, 2017
@chrjohn chrjohn merged commit f360ccd into quickfix-j:master Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants