Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow number of retries on failover #624

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MuhammadhAadhil
Copy link

@MuhammadhAadhil MuhammadhAadhil commented Mar 24, 2023

Fixes #250
Enhancement.

@chrjohn chrjohn changed the title https://github.com/quickfix-j/quickfixj/issues/250 Allow number of retries on failover Apr 6, 2023
@chrjohn
Copy link
Member

chrjohn commented Apr 6, 2023

Hi @MuhammadhAadhil

thanks for the PR. In the meantime there was a request which is quite similar #402. See my comment there: #402 (comment)

The question is: do you want to give it a try to introduce some kind of interface which enables users to customize the failover behaviour? The default behaviour could still have your changes with the number of retries (so we would have an improvement to the status quo).

Cheers
Chris

@MuhammadhAadhil
Copy link
Author

Hi @chrjohn ,

It is an interesting change. Let me see on this and keep you posted.

@MuhammadhAadhil
Copy link
Author

Hi @chrjohn , May i know when this change will be added to the release. If there any more actions needed from my side, please be kind enough to guide me since this is my first change.

@chrjohn
Copy link
Member

chrjohn commented Aug 17, 2023

Hi @MuhammadhAadhil , do you wanted to consider the points from #624 (comment) ?

@MuhammadhAadhil
Copy link
Author

Hi @chrjohn , Actually i'm not in a position to work on that enhancement at the moment. This year being a little hard on my career. Lets give the feature with next release. We can enhance in future.#624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail over retry attempt
2 participants