Enhancement: First field in repeating group as delimiter

[andreydp]

Fixes #675

[chrjohn]

Thanks for the PR! 👍
Could you please also add the configuration to the validation section of https://github.com/quickfix-j/quickfixj/blob/master/quickfixj-core/src/main/doc/usermanual/usage/configuration.html

Thanks in advance

[andreydp]

Thanks, I've added changes to the documentation and also added session parameter.

[chrjohn]

Could you please check my comments. Thank you. :)

[andreydp]

Thanks for the review, pushed changes to the branch.

[noblemaster]

We are having the same problem with repeating group delimiters. It would be nice to have this merged.

[noblemaster]

@andreydp We are having the same problem. Would it be OK if I rework your pull request for the new 3.0.0 release? I'll get started beginning of next week in case I don't hear back.

[andreydp]

Hi @noblemaster. I can adapt my changes for 3.0.0 release in the next few days.

[noblemaster]

@andreydp Thanks! I can assist/review as needed. 👍

[andreydp]

@noblemaster working on the changes, will push soon, sorry for the delay.

[andreydp]

@noblemaster I've merged latest master

[noblemaster]

The change looks good! I have nothing to add. 👍

I would approve it. That's a nice addition. @chrjohn I don't have the powers to approve, so you will have to have a look too. Thanks.

[philipwhiuk]

Will review tomorrow - have similar stuff in #876 which I'm hoping to work on this month.

[chrjohn]

This feature only works when unordered group fields are not validated. Does it make sense to throw an error or generate a warning when this feature is enabled and unordered group fields are validated?
@andreydp @noblemaster @philipwhiuk

[chrjohn]

We should mention the dependency on setCheckUnorderedGroupFields.

[noblemaster]

@andreydp Can you update the documentation? Thanks :)

[andreydp]

Documentation updated, thanks.

[noblemaster]

This feature only works when unordered group fields are not validated. Does it make sense to throw an error or generate a warning when this feature is enabled and unordered group fields are validated?

I would just generate a warning if the feature is enabled & validation is on.

[andreydp]

This feature only works when unordered group fields are not validated. Does it make sense to throw an error or generate a warning when this feature is enabled and unordered group fields are validated?

I would just generate a warning if the feature is enabled & validation is on.

I will add warning then