Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize Resend, if configured. #688

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

AbhinavAtul
Copy link

Prioritize Resend, if configured, allows lagging counter-party app to catch up by scheduling resend responses first over new/pending messages.

Abhinav Atul and others added 6 commits November 27, 2023 15:03
@chrjohn chrjohn changed the title QFJ-271: Prioritize Resend, if configured. Prioritize Resend, if configured. Jan 5, 2024
@chrjohn
Copy link
Member

chrjohn commented Jan 5, 2024

This probably relates to #271

@philipwhiuk you created #271 but this seems to be the other way round. You wanted to throttle resend request responses, this PR right here wants to prioritize them. So it seems we have two competing concepts here. Any thoughts?

@philipwhiuk
Copy link
Contributor

philipwhiuk commented Sep 13, 2024

In terms of priority that wasn't really a concern it was more about rate-limiting - I imagine the counter-party would have had a similar issue if the actual flow was high. On an app level we try not to route stuff to sessions that are pending a resend.

My intention is to spend some of next week on re-implementing some read throttling code we had in our app. I wanted to rebase our changes first. At that point it seemed sensible to upstream as much as possible to minimise the work we have to do to maintain our internal fork (which is necessary in order to fix production issues ASAP).

But done properly it should allow a write throttle too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants