Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataDictionary: removed check for empty message body #735

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

chrjohn
Copy link
Member

@chrjohn chrjohn commented Dec 13, 2023

Fixes #636

There is no reason why a message shouldn't have only header and trailer, see message type n.

image

https://fiximate.fixtrading.org/legacy/en/FIX.4.4/body_5255110.html

Header and trailer should not allowed to be empty. Unit tests need to be updated.

@chrjohn chrjohn added this to the QFJ 3.0.0 milestone Dec 13, 2023
@chrjohn chrjohn marked this pull request as draft December 13, 2023 16:20
@chrjohn chrjohn changed the title removed check for empty message removed check for empty message body Dec 13, 2023
@chrjohn chrjohn changed the title removed check for empty message body DataDictionary: removed check for empty message body Dec 14, 2023
@chrjohn chrjohn marked this pull request as ready for review December 18, 2023 21:12
@chrjohn chrjohn merged commit ff0f6e0 into master Dec 19, 2023
21 checks passed
@chrjohn chrjohn deleted the chrjohn-empty-message branch December 19, 2023 14:44
chrjohn added a commit that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataDictionary.load() throws exception on message with no fields
1 participant