Skip to content

Conversation

@the-thing
Copy link
Contributor

@the-thing the-thing commented Jan 17, 2025

Small SSL test improvements.

Changes

  • SNI algorithm should be set for two cases
  • Oracle JVM gives slightly different error message for quickfix.mina.ssl.SSLCertificateTest#shouldFailWhenHostnameDoesNotMatchServerName test case (error message is prepended with exception class name)

expected: "No name matching localhost found"
actual: "java.security.cert.CertificateException: No name matching localhost found"

I think there are different messages in JVM's higher than > 17 which might require changes in the future

@chrjohn chrjohn merged commit 9e81970 into quickfix-j:master Jan 17, 2025
12 checks passed
@chrjohn chrjohn added this to the QFJ 3.0.0 milestone Jan 17, 2025
@chrjohn
Copy link
Member

chrjohn commented Jan 17, 2025

Thank you

@chrjohn chrjohn mentioned this pull request Jan 18, 2025
@the-thing the-thing deleted the fix-test-assertion branch January 18, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants