Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve concurrent map read and map write by making Fieldmap thread-safe & avoiding recycling of addresses #485

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Solve concurrent map read and map write by making Fieldmap thread-safe & avoiding recycling of addresses #485

merged 2 commits into from
Jun 21, 2022

Conversation

waheedoo
Copy link
Contributor

@waheedoo waheedoo commented Apr 3, 2022

We tried to use the library as it is in our integration, but we found out that it has some serious issues:

  1. Fieldmap is not thread-safe.
  2. Recycling of quickfix.Message addresses and re-using them are causing a problem when forwarding these addresses and reading them via:

FromApp(message *Message, sessionID SessionID) MessageRejectError

FromApp(message *Message, sessionID SessionID) MessageRejectError

In this PR we solved both issues, and it works now perfectly fine for us.

This PR should solve the following issues as well:
#460
#372
#371
#320

@sanlem
Copy link

sanlem commented Jun 20, 2022

please somebody merge this...

@ackleymi ackleymi merged commit efd43e2 into quickfixgo:main Jun 21, 2022
@sylr sylr mentioned this pull request Oct 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waheedoo @sanlem @ackleymi