Handle string slices correctly in JS_ToCString #1184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JS_ToCStringLen2 returns a pointer to a string that is prefixed by a JSString struct. It lets JS_FreeCString free the memory through simple pointer arithmetic. JS_ToCStringLen2 has an optimization for ASCII-only 8 bit strings where it returns early but that optimization is not valid for slice strings. They reference their string data indirectly and said data is not prefixed by a JSString. Fixes: quickjs-ng#1178
bnoordhuis
changed the title
saghul
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS_ToCStringLen2 returns a pointer to a string that is prefixed by a JSString struct. It lets JS_FreeCString free the memory through simple pointer arithmetic.
JS_ToCStringLen2 has an optimization for ASCII-only 8 bit strings where it returns early but that optimization is not valid for slice strings. They reference their string data indirectly and said data is not prefixed by a JSString.
Fixes: #1178