Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple definition compile errors #32

Merged
merged 1 commit into from
Dec 24, 2019

Conversation

andre-nguyen
Copy link
Contributor

I dropped wise_enum into my library and I was getting multiple definition compile errors on these two non-templated methods.

Fix taken from multiple places such as https://stackoverflow.com/questions/49542632/inclusion-of-a-header-only-library-to-multiple-files-producing-a-linker-error

@quicknir Hopefully you're still maintaining this library?

@quicknir quicknir merged commit 8a1ec93 into quicknir:master Dec 24, 2019
@quicknir
Copy link
Owner

@andre-nguyen Doing my best :-) Haven't had time to sink a significant amount of time into new features, and tracking down issues on MSVC is hard for me since I don't work on windows, but I'm trying. Thanks for your patch, silly omission on my part. Feel free to let me know any feedback, positive or critical!

@andre-nguyen
Copy link
Contributor Author

@quicknir I'd say wise_enum is the first time I see a good reflection library. Features beyond type safety, proper scoping, iteration and C++11 support seem like fluff to me. Probably more interesting (personally) would be good maintenance (including multi-compiler support) and possibly a CMakeLists.txt which allows proper inclusion of wise_enum as a submodule. I do have a windows partition so I would be open to helping on msvc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants