chore: lint fixes #356
Merged
chore: lint fixes #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 21, 2023 13:33
joe-bowman
reviewed
Mar 21, 2023
joe-bowman
reviewed
Mar 21, 2023
joe-bowman
reviewed
Mar 21, 2023
joe-bowman
reviewed
Mar 21, 2023
joe-bowman
reviewed
Mar 21, 2023
|
This suggests to me that it is still relevant in 0.46? https://github.com/cosmos/cosmos-sdk/blob/5023392bd9718679668dd8e88a792a6defa63c00/types/module/module.go#LL294C3-L296C4 |
added 2 commits
March 22, 2023 09:38
joe-bowman
pushed a commit
that referenced
this pull request
Mar 28, 2023
* update lint * easy fixes * loop fixes * review suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Summary
Fixes failing lint
2.Type of change
3. Implementation details
Golangci-lint action was bumped to
v1.52.0which started complaining about a bunch of code. This PR bumps our version oflintand makes the according changes to fix the lint.NewHandlerfunctions (not needed anymore).Ones to check (simplified logic that should be verified):